Re: current->timeout = jiffies + ? -> schedule_timeout(?)

Steven N. Hirsch (shirsch@adelphia.net)
Wed, 4 Nov 1998 20:00:40 -0500 (EST)


On Wed, 4 Nov 1998, Linus Torvalds wrote:

> On Wed, 4 Nov 1998, Stephen Frost wrote:
> >
> > Is everything that does a 'current->timeout = jiffies + x;' obsolete and
> > needing to be redone as 'schedule_timeout(x);'?
>
> Yes. However, I've done some of it already. Sending me patches is still a
> good idea, though.

Ok, color this a good idea then:

--- linux/net/appletalk/ddp.c.orig Thu Aug 27 22:33:08 1998
+++ linux/net/appletalk/ddp.c Wed Nov 4 18:09:47 1998
@@ -383,9 +383,8 @@
/*
* Defer 1/10th
*/
- current->timeout = jiffies + (HZ/10);
current->state = TASK_INTERRUPTIBLE;
- schedule();
+ schedule_timeout(HZ/10);
if(atif->status & ATIF_PROBE_FAIL)
break;
}

Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/