interrupts enabled in scsi_request_queueable?

Paul Mackerras (paulus@cs.anu.edu.au)
Wed, 4 Nov 1998 13:44:54 +1100

Some Linux/PPC users have reported panics on systems with two scsi
disks attached to separate host adaptors when doing a lot of I/O to
both disks at the same time. The panic is "Inactive in
scsi_request_queueable".

Looking at the code, there is a comment at the top of
drivers/scsi/scsi.c:scsi_request_queueable() which says that
interrupts must be disabled when it is called. In do_sd_request()
(drivers/scsi/sd.c), which calls scsi_request_queueable, there are
comments where there were once calls to save_flags(), cli(), and
restore_flags(), but those calls are no longer there.

Could someone who understands the scsi code comment on whether the
calls to cli() etc. were taken out deliberately and for good reasons?

Thanks,
Paul.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/