>Just based on semantic considerations, timer_add()/timer_delete() makes
>sense but timer_pending() makes races. In fact timer_pending() may just
The only reasons to use timer_pending() is code readibility according to
me.
cd /usr/src/linux/net/ipv4/
grep -n -e timer\.prev *.c /dev/null
tcp.c:1338: if (sk->state == TCP_FIN_WAIT2 && !sk->timer.prev)
tcp_output.c:957: if (!tp->delack_timer.prev) {
tcp_timer.c:89: if(tp->probe_timer.prev)
tcp_timer.c:115: if(tp->retransmit_timer.prev)
tcp_timer.c:117: if(tp->delack_timer.prev)
tcp_timer.c:119: if(tp->probe_timer.prev)
tcp_timer.c:618: if (tcp_slow_timer.prev) {
timer.c:55: if(t->timer.prev)
grep finished (matches found) at Tue Nov 3 23:58:36
This is a second proof that I was not so crazy accessing for the .prev
(really I was using the bogus .next ;-) field by hand (in C) yesterday
;-).
Andrea Arcangeli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/