[PATCH] ad1848 doesn't correctly free IRQ on unloading --> oops.

David Woodhouse (David.Woodhouse@mvhi.com)
Thu, 29 Oct 1998 20:26:16 +0000


This is a multipart MIME message.

--==_Exmh_13353908440
Content-Type: text/plain; charset=us-ascii

ad1848 registers the irq with devc->dev_no as the 'instance data' or whatever
it's called. Later it tries to free it, just passing NULL.

The result is that the IRQ isn't unregistered when the driver unloads, causing
an oops if you later read /proc/interrupts.

--==_Exmh_13353908440
Content-Type: text/plain ; name="ad1848-fix"; charset=us-ascii
Content-Description: ad1848-fix
Content-Disposition: attachment; filename="ad1848-fix"

Index: ad1848.c
===================================================================
RCS file: /cvs/linux/drivers/sound/ad1848.c,v
retrieving revision 1.1.1.6
diff -u -r1.1.1.6 ad1848.c
--- ad1848.c 1998/10/29 00:07:36 1.1.1.6
+++ ad1848.c 1998/10/29 20:26:02
@@ -1935,7 +1935,7 @@
if (!share_dma)
{
if (irq > 0)
- free_irq(devc->irq, NULL);
+ free_irq(devc->irq, (void *)devc->dev_no);

sound_free_dma(audio_devs[dev]->dmap_out->dma);

--==_Exmh_13353908440
Content-Type: text/plain; charset=us-ascii

---- ---- ----
David Woodhouse David.Woodhouse@mvhi.com Office: (+44) 1223 810302
Project Leader, Process Information Systems Mobile: (+44) 976 658355
Axiom (Cambridge) Ltd., Swaffham Bulbeck, Cambridge, CB5 0NA, UK.
finger dwmw2@ferret.lmh.ox.ac.uk for PGP key.

--==_Exmh_13353908440--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/