Re: TCP bug?

Andi Kleen (ak@muc.de)
29 Oct 1998 16:29:53 +0100


In article <Pine.LNX.3.96.981029143207.27071A-100000@ps.cus.umist.ac.uk>,
Riley Williams <rhw@bigfoot.com> writes:

> It sounds like the best option would be to have a generic function
> called skb_reallic_head_and_tail_room which allocated either or both
> as required, and define a pair of macros called skb_realloc_headroom
> and skb_realloc_tailroom which just called the generic function with
> an extra zero parameter for the unwanted area...

This is a bad idea because it would add unnecessary checks in important
fast paths (packet forwarding) - because it unlikely that gcc will be smart
enough to remove the redundant checks.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/