Re: SB and 2.1.126 [NOT THE COMPILE PROBLEM]

Mike (mike@oakley.keble.ox.ac.uk)
Mon, 26 Oct 1998 21:09:20 +0000 (GMT)


On Mon, 26 Oct 1998, Alex Buell wrote:

> On Mon, 26 Oct 1998, Mike wrote:
>
> > -#define SOUND_MIXER_OUTSRC 0xfa /* Arg contains a bit for each input source to output */
> > -#define SOUND_MIXER_OUTMASK 0xf9 /* Arg contains a bit for each supported input source to output */
>
> > - sb = acct_file->f_dentry->d_inode->i_sb;
> > + sb = acct_file->f_dentry->f_inode->i_sb;
> > if (!sb->s_op || !sb->s_op->statfs)
> > return;
>
> NO NO NO NO NO!!! This patch is WRONG! WRONG WRONG WRONG. It's the other
> way around!!!!!! ARGHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH!
>
> This is the second wrong patch I've seen sent to the mailing list in the
> last 2 days, hence my reaction.
>
Ooops.

<runs and hides under the table>

--
Mike <rickettm@ox.compsoc.net>

Tobacco is a filthy weed, That from the devil does proceed; It drains your purse, it burns your clothes, And makes a chimney of your nose. -- B. Waterhouse

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/