>
>
>On Wed, 21 Oct 1998 storner@image.dk wrote:
>>
>> I propose this patch should go into 2.1.126:
>
>Applied, looks fine. Although I suspect looping is always the wrong thing
>to do (it should really be "try _once_ to redo it" or something), but this
>is better than doing so forever for atomic allocations.
Please remove the loop also from the not atomic allocation. The kernel is
perfectly allowed to return NULL from __get_free_pages() in ATOMIC or
GFP_WAIT context. If the mm allocator returns NULL and the system is not
OOM this is a different issue and the loop is hiding a bug in
__get_free_pages().
Andrea Arcangeli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/