Re: isdn performance problem in 2.1[19]-[22]

David Woodhouse (David.Woodhouse@mvhi.com)
Wed, 30 Sep 1998 01:21:27 +0100


eis@baty.hanse.de said:
> Could those of you observing performence problems with isdn on 2.1.x
> please try the following patch? It's against the current cvs version,
> but should also apply against stock 2.1.122 kernel.

> Henner

> --- 2.1.122-i4ldev/drivers/isdn/isdn_net.c Mon Sep 7 23:23:03 1998
> +++ 2.1.122-ix25/drivers/isdn/isdn_net.c Fri Sep 25 21:47:41 1998 @@
> -1225,12 +1226,14 @@
> if (ret == len) {
> lp->transcount += len;
> clear_bit(0, (void *) &(ndev->tbusy));
>+ mark_bh(NET_BH);
> return 0;
> }
> if (ret < 0) {
> dev_kfree_skb(skb);
> lp->stats.tx_errors++;
> clear_bit(0, (void *) &(ndev->tbusy));
>+ mark_bh(NET_BH);
> return 0;
> }
> return 1;
>

A bit early to tell, because it sometimes takes our router a week to develop
problems, but given that my initial diagnosis was "something's forgetting to
kick a bottom-half somewhere", I'd be willing to bet that the problem doesn't
recur with this patch in place.

Could this be a candidate for 2.1.124, perhaps (ignoring the tbusy debate for
the moment)?

---- ---- ----
David Woodhouse David.Woodhouse@mvhi.com Office: (+44) 1223 810302
Project Leader, Process Information Systems Mobile: (+44) 976 658355
Axiom (Cambridge) Ltd., Swaffham Bulbeck, Cambridge, CB5 0NA, UK.
finger dwmw2@ferret.lmh.ox.ac.uk for PGP key.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/