Bill, this makes perfect sense when looking at your changes. Previously,
the superblock was unlocked before calling check_disk_change(). Now,
it is unlocked after calling check_disk_change(). With all the
reordering you've done with error conditions, I'm not sure how you
want to handle this one. As a test to make sure this is indeed the
case, apply this pseudo patch to your fs/isofs/inode.c:
+unlock_super(s);
printk("isofs_read_super: checking disk change\n");
if(!check_disk_change(dev)) {
printk("isofs_read_super: calling unlock_super\n");
/* turn off ide-cd debugging */
ide_cd_debug = 0;
- unlock_super(s);
printk("isofs_read_super: unlock_super done\n");
return s;
}
+lock_super(s);
printk("isofs_read_super: disk change failed!\n");
It should fix the problem. It would seem to me there is something a
bit wrong in check_disk_change(). If it gets an error as it appears
to in this case, it assumes the disk has been changed. Should the
check be instead:
if (fops->check_media_change(dev) <= 0)
return 0;
?
Erik, the ide-cd code is completely clear of any blame.
- Gordon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/