Boot Logo Question

Clifford Wolf (clifford@clifford.at)
Wed, 26 Aug 1998 22:25:22 +0200 (MEST)


I'm working here on a cleaner implementation of my Boot Logo Selection
Patch and have a question:

The file linux/include/asm/linux_logo.h defines LINUX_LOGO_COLORS. This
is the number of colors the logo will need in the colormap and must be
less than 224. In the case of most architecures this number is 221 - but
not for all.

The file linux/include/linux/linux_logo.h contains the real logo data and
is included by linux/include/asm/linux_logo.h (on most archs). In this
file one checks now if LINUX_LOGO_COLORS has the right value for this
logo. If the number should be wrong for some reason, the logo is not
included and a make will result in a compiler error.

Now my question: what's wrong with defining LINUX_LOGO_COLORS direct in
the header file which keeps the logo?

Another question: INCLUDE_LINUX_LOGOBW is defined in
linux/include/asm-{mips,ppc}/linux_logo.h but not used at all. Since
INCLUDE_LINUX_LOGO16 is used in allmost all include/asm-*/linux_logo.h
files - wouldn't it be sensefull to use INCLUDE_LINUX_LOGOBW in all logos
to or to drop INCLUDE_LINUX_LOGOBW _and_ INCLUDE_LINUX_LOGO16?

- clifford

-- -- -- -- -- -- -- -- -- -- -- -- --
Clifford Wolf
magnet - Internet at Work IRC: efnet / clifford
Director of System Development http://www.clifford.at/
e-mail: c.wolf@magnet.at email: god@clifford.at

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html