Re: copy_from_user() fix

H. Peter Anvin (hpa@transmeta.com)
25 Aug 1998 06:40:14 GMT

Followup to: <199808250429.OAA10383@vindaloo.atnf.CSIRO.AU>
By author: Richard Gooch <rgooch@atnf.csiro.au>
In newsgroup: linux.dev.kernel
>
> Jamie Lokier writes:
> > On Tue, Aug 25, 1998 at 01:45:12AM +0100, Jamie Lokier wrote:
> > > Will I don't agree with the feature either, all we're talking about is
> > > adding one line to the page fault handler: send_sig(SIGSEGV). Nothing
> > > else needs to change, does it?
> >
> > I just changed my mind.
> >
> > I bet no applications at all currently check for EFAULT from system
> > calls, unless they're really weird and are doing it to behave _as if_
> > they'd received SIGSEGV. Actually I bet they don't bother because every
> > syscall would need to be wrapped. I'm theorising that this could screw
> > up Wine in some unusual but valid cases.
>
> Well, you're wrong. I do have applications that explicitely check for
> EFAULT. I *don't* want them to receive SEGV.

So, what happens if the libc/kernel interface is changed? You're
screwed, because your code is broken.

-hpa

-- 
    PGP: 2047/2A960705 BA 03 D3 2C 14 A8 A8 BD  1E DF FE 69 EE 35 BD 74
    See http://www.zytor.com/~hpa/ for web page and full PGP public key
        I am Bahá'í -- ask me about it or see http://www.bahai.org/
   "To love another person is to see the face of God." -- Les Misérables


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html