Re: NFS file locking broken (take 2)

Bill Hawes (whawes@transmeta.com)
Mon, 24 Aug 1998 07:55:41 -0700


Steven N. Hirsch wrote:

> The testcase was attached to my message. Let me know if the mailer
> glitched and you failed to receive it?
>
> Bill Hawes posted a patch that seems to alleviate the immediate symptoms.
> Can you two gentlemen each take a quick look at what the other has
> suggested? I will try hj's patch this evening.
>
> Many, many thanks for your attention to this problem!

Both patches fix the problem -- the immediate problem was that a pointer to
non-allocated memory was being freed, and allocated memory wasn't being freed. I
made additional changes to simplify the grantargs code.

The lockd code as written could never have worked, so apparently the server-side
locking has had little or no testing.

Regards,
Bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html