Re: Simple devpts fix against 2.1.116
Chris Atenasio (root@lilo.dyn.ml.org)
Thu, 20 Aug 1998 20:18:52 -0400 (EDT)
> > Does it really make sense for mounting devpts to bomb if you don't specify
> > any options? I'm no devpts expert but this works for me.
> >
> >
> > --- linux-2.1.116/fs/devpts/inode.c Wed Aug 19 19:14:55 1998
> > +++ linux/fs/devpts/inode.c Wed Aug 19 22:46:56 1998
> > @@ -82,7 +82,6 @@
> > umode_t mode = 0600;
> > char *this_char, *value;
> >
> > - if ( !options ) return 1;
> > for (this_char = strtok(options,","); this_char; this_char =
> > strtok(NULL,",")) {
> > if ((value = strchr(this_char,'=')) != NULL)
> > *value++ = 0;
> >
> >
>
> You know... this doesn't check for no options... it checks that you
> didn't pass it a null pointer...
That isn't what happens when no options are passed? My logic being after this
patch I could mount devpts without options. (I assumed that strok(NULL,',')
returned null.)
- Chris
--------------------------------------------------------------------------------
Chris Atenasio (chrisa@ultranet.com) -- Friends dont let friends use Windows.
Send me mail with subject "send pgp key" or "word of the day" for autoresponse.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html