Re: [PATCH] quadratic behaviour in ext2

Richard Henderson (rth@dot.cygnus.com)
Wed, 12 Aug 1998 11:53:18 -0700


On Wed, Aug 12, 1998 at 04:59:48AM +0200, Andries.Brouwer@cwi.nl wrote:
> Rereading my letter I notice the first flaw:
> since de is used as a pointer we have to guarantee
> some alignment. So, the
> if (de_len <= 0)
> had better be
> if (de_len <= 0 || (de_len % 4) != 0)

A pointer? Or an ext2_ino_t? If the former, please use
sizeof(void*), not 4. Actually, in either case please use
sizeof and the appropriate type.

r~

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html