BUILD_SMP_TIMER_INTERRUPT not needed movl

Andrea Arcangeli (arcangeli@mbox.queen.it)
Tue, 11 Aug 1998 12:08:35 +0200 (CEST)


>From arch/i386/kernel/irq.h

#define BUILD_SMP_TIMER_INTERRUPT(x) \
asmlinkage void x(struct pt_regs * regs); \
__asm__( \
"\n"__ALIGN_STR"\n" \
SYMBOL_NAME_STR(x) ":\n\t" \
"pushl $-1\n\t" \
SAVE_ALL \
"movl %esp,%eax\n\t" \
^^^^^^^^^^^^^^^^^^^^^^
"pushl %eax\n\t" \
"call "SYMBOL_NAME_STR(smp_##x)"\n\t" \
"addl $4,%esp\n\t" \
"jmp ret_from_intr\n");

I don' t think that the underlined line is needed. Why not to push %esp
directly?

Andrea[s] Arcangeli

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html