Re: fixmap align initialization

MOLNAR Ingo (mingo@chiara.csoma.elte.hu)
Mon, 10 Aug 1998 21:14:44 +0200 (CEST)


On Mon, 10 Aug 1998, Andrea Arcangeli wrote:

> unsigned long apic_phys, ioapic_phys;
>
> + memory_start = PAGE_ALIGN(memory_start);

we dont need this one here, as paging_init() aligns on page boundary
already.

> - start_mem &= PAGE_MASK;
> + start_mem = PAGE_ALIGN(start_mem);

yep. But we dont need this line either, at all. I dont understand why it
got added originally ...

> - for (idx=1; idx < __end_of_fixed_addresses; idx += PTRS_PER_PTE)
> + for (idx=0; idx < __end_of_fixed_addresses; idx += PTRS_PER_PTE)

oops, right. This one still has a small bug when we have exactly 4092k
fixmap mappings (quite unlikely :), so we need rather this one:

+ for (idx=1; idx <= __end_of_fixed_addresses; idx += PTRS_PER_PTE)

-- mingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html