Re: 2.1.114 fails build on i386

Linus Torvalds (torvalds@transmeta.com)
Tue, 4 Aug 1998 10:34:06 -0700 (PDT)


On Mon, 3 Aug 1998, Horst von Brand wrote:
>
> No, you misunderstood your very own kludge ;-) gcc-2.7.2.3 (at least) hates
> empty structure initializers anywhere.

No, they work on their own - it seems to be only inside other structure
initializers that they break. We use empty initializers all over the place
in other places.

> The ugly hack used pior to 2.1.114
> works by moving the empty initializer to the end of the structure, and then
> just leaving it out there. I just finished compiling a kernel with the
> patch I sent earlier, it boots fine. In fact, that's what I'm running right
> now.

That's not what I'm going to use. I wanted the SMP stuff to be "close" to
the other process priorities etc, for cache reasons. I've added a dummy
"gcc_is_buggy" entry to the UP spinlock, and while it will never be used
it at least will allow buggy compilers to compile the thing.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html