Re: [PATCH] framebuffer devfs support (umm redone..)
Richard Gooch (Richard.Gooch@atnf.CSIRO.AU)
Thu, 30 Jul 1998 23:12:40 +1000
Geert Uytterhoeven writes:
> On Wed, 29 Jul 1998, Mark 'segfault' Guzman wrote:
> > Welp i went back and noticed my stupidity (thanks to many emails notifying me of it)
> > now the code is in fbmem.c only. I changed it to make only numerical entries in /dev/fb
> > and link them as fb<device number> in /dev. It also now only creates entries for the devices
> > you have. Works perfectly on my box. If anybody has any complaints, suggestions, objections
> > tell me. If something seems wrong, it probably is so tell me.
>
> One caveat: frame buffer devices can be loadable modules.
> {register,unregister}_framebuffer() will tell you when a new bloke enters or
> leaves the game.
Geert is right. Please update the patch to cope with module
unloading. A hint: use devfs_mk_dir() to create the "fb" subdirectory
first, and save the handle that is returned. Then when you unload the
module, you can just unregister the handle and it will automatically
unregister all the entries in /dev/fb/
Once this is done, it looks like your patch can go into my patch.
Regards,
Richard....
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html