Re: 2.1.111: CONSOLE: STILL reproducible oddities

Anders Melchiorsen (postmaster@and.nospam.kampsax.k-net.dk)
27 Jul 1998 20:38:32 +0200


Martin Mares <mj@albireo.ucw.cz> writes:

> The console code was full of nasty races even in 2.0.X, but they were
> showing up very rarely and they usually caused only misscrolled screen.
> The following patch should fix them, please test it.

I applied it and noticed a few warnings (not really related to your
patch, expect it is in the same file). The patch below silents them by
casting `pos' like it is done lots of other places.

It seems your patch fixes the problem with blank display (I never had
it crash). I still think I have less scroll back buffer than I used
to, though.

--- linux/drivers/char/console.c~ Mon Jul 27 20:08:38 1998
+++ linux/drivers/char/console.c Mon Jul 27 20:14:15 1998
@@ -2704,7 +2704,7 @@

u16 vcs_scr_readw(int currcons, u16 *org)
{
- if (org == pos && softcursor_original != -1)
+ if (org == (u16 *)pos && softcursor_original != -1)
return softcursor_original;
return scr_readw(org);
}
@@ -2712,7 +2712,7 @@
void vcs_scr_writew(int currcons, u16 val, u16 *org)
{
scr_writew(val, org);
- if (org == pos) {
+ if (org == (u16 *)pos) {
softcursor_original = -1;
add_softcursor(currcons);
}

-- 
Regards, Anders
(address is valid)

Backup not found: (A)bort (R)etry (P)anic

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html