I thought that doing the test for every page would be more costly, as
the count won't always go over the limit. Also, that would have made a
big arch-specific patch that I couldn't test.
I looked your patch over some more, it seems mostly ok the more I
think about it. The reason I liked my change is that in the most
common cases the code would take no function calls during page table
piece liberation because in the normal case we're within the water
marks.
A lot of people may be running useful background loops that prevent the
idle thread from ever running. (e.g. the RC5 cracking code or such.) So
the issue of whether the idle thread will properly regulate the cache
size remains, but this at least keeps it below the high water mark.
I agree.
Later,
David S. Miller
davem@dm.cobaltmicro.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html