I really feel strongly that commenting (style) is very personal and you
are indirectly insulting the author by modifying comments.
This is especially the case in the development style that the kernel
is being developed in (imho)
:: nopzor
Trevor Johnson wrote:
> > Look at the top of the file you are changing to see who the maintainer
> > is, if not listed in the MAINTAINERS file. I thought this was common
> > sense, and it is why Martin is so ticked about not getting notified
> > because his name is in fact at the top of every source file you
> > changes which he had some gripe with.
>
> Here's the beginning of the first one he referred to (where I made the
> mistake with "asciiz"):
>
> !
> ! setup.S Copyright (C) 1991, 1992 Linus Torvalds
> !
> ! setup.s is responsible for getting the system data from the BIOS,
> ! and putting them into the appropriate places in system memory.
> ! both setup.s and system has been loaded by the bootblock.
> !
> ! This code asks the bios for memory/disk/other parameters, and
> ! puts them in a "safe" place: 0x90000-0x901FF, ie where the
> ! boot-block used to be. It is then up to the protected mode
> ! system to read them from there before the area is overwritten
> ! for buffer-blocks.
> !
> ! Move PS/2 aux init code to psaux.c
> ! (troyer@saifr00.cfsat.Honeywell.COM) 03Oct92
> !
> ! some changes and additional features by Christoph Niemann,
> ! March 1993/June 1994 (Christoph.Niemann@linux.org)
> !
> ! add APM BIOS checking by Stephen Rothwell, May 1994
> ! (Stephen.Rothwell@pd.necisa.oz.au)
> !
> ! High load stuff, initrd support and position independency
> ! by Hans Lermen & Werner Almesberger, February 1996
> ! <lermen@elserv.ffm.fgan.de>, <almesber@lrc.epfl.ch>
> !
> ! Video handling moved to video.S by Martin Mares, March 1996
> ! <mj@k332.feld.cvut.cz>
> !
> ! Extended memory detection scheme retwiddled by orc@pell.chi.il.us (david
> ! parsons) to avoid loadlin confusion, July 1997
>
> As you see, several people are mentioned as having worked on it; Mr. Mares
> isn't even the most recent, and it's not clear that anyone besides Linus
> is maintaining it now. I have the impression that there are many files
> which are no longer maintained by their authors, don't mention their
> authors, mention the authors without giving an e-mail address, or have RCS
> IDs from people who aren't maintaining them. As far as I know, that's why
> the MAINTAINERS file exists, and that's why I relied on it.
>
> > I really am getting ticked as well about these gratuitous
> > spelling/grammer changes. If I put fucking "Uh-huh" in a comment, it
> > is a part of my personality and my style and I wanted it there just
> > like that, and there is no good reason to remove it. This is getting
> > out of control.
>
> "Uh huh" is slang for "yes" but in the instances I noticed, it seemed to
> make little sense to read it that way. The author seemed to mean "uh oh",
> but since an obvious problem was described each time, I didn't see the
> need to add that. Here are those sections:
>
> - /* Uhhuh. We're _really_ low on memory. Now we just
>
> - * Uhhuh.. We need to expand. Note that "grow_inodes()" will
>
> - * Uhhuh.. Things didn't work out. Return zero to tell the
>
> Each time, I just deleted "uhhuh". I didn't mean to take away the fun
> for anyone, just wanted to make things a tiny bit clearer. :)
> ___
> Trevor Johnson
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.rutgers.edu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu