RE: 2.1.107 breaks vmstat (procps)

Manuel J. Galan (manolow@step.es)
Thu, 25 Jun 1998 14:38:46 +0100 (WEST)


I think that somebody's hand went too far away with spelling fixes...

--------------------------------------------
--- linux/fs/proc/array.c.old Thu Jun 25 14:30:00 1998
+++ linux/fs/proc/array.c Thu Jun 25 14:30:50 1998
@@ -232,7 +232,7 @@

#ifdef __SMP__
len = sprintf(buffer,
- "CPU %u %u %u %lu\n",
+ "cpu %u %u %u %lu\n",
kstat.cpu_user,
kstat.cpu_nice,
kstat.cpu_system,

-------------------------------------------

Now I get this ugly /proc/stat
--------------------------------------
CPU 19180 0 6705 1672393 <- capitalized
cpu0 10552 0 4997 833590 <- not capitalized
cpu1 8628 0 1708 838803 <- not capitalized
disk 13260 822 559 2845 <- not capitalized
disk_rio 8219 815 551 2740
...
---------------------------
If we agree on CPU then CPU0, CPU1, Disk, etc. else
cpu, cpu0, cpu1 and so on...

On 25-Jun-98 Mike Black wrote:
> Linux 2.1.107 causes vmstat to get s SIGSEG due to changes in /proc/stat
> format.
>
> The fix for procps-1.7 is to change vmstat.c, line 224 and 225 to:
[...]

~~~
Manuel J. Galan <manolow@step.es>
Sent on 25-Jun-98.
~~~
Due to a shortage of devoted followers, the production of great leaders
has been discontinued.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu