piss poor change in ncr53c8xx/linux-2.1.104

Gerard Roudier (groudier@club-internet.fr)
Sun, 7 Jun 1998 17:49:08 +0200 (MET DST)

Hi Mister X! if you want to maintain the ncr53c8xx driver by yourself,
let me know. I do consider that sending directly patches to official
guys without having submitted the change to the maintainer (at least
for his information) to be act of rudeness.

Obviously, this does not apply to typo fixes and I thank a lot people
who spend hours fixing them.

FOR YOUR INFORMATION, THIS DRIVER IS STILL MAINTAINED.

Here is the poor piss I got into the face from 2.1.104 patch:

--- ncr53c8xx.c.orig Sat May 16 15:32:49 1998
+++ ncr53c8xx.c Sun Jun 7 16:37:04 1998
@@ -369,8 +369,8 @@

static void DELAY(long us)
{
- for (;us>1000;us-=1000) udelay(1000);
- if (us) udelay(us);
+ if (us/1000) mdelay(us/1000);
+ if (us%1000) udelay(us%1000);
}

What was wrong in the initial code?

BTW, I do consider using several DIVISIONS when 1 COMPARISON is
enough to be BAD PROGRAMMING, expecially when the code is intended
to deal with a fiew MICRO-SECONDS.

FYI, this change will not be incorporated in my personal driver version,
which is currently 2.6n and will become 3.0 soon with a patch against
2.0.34 followed by the announce that I stop maintaining ncr53c8xx 2.5
driver series.

Good luck!

Gerard.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu