Volatile asm in bios32.c

Martin Mares (mj@ucw.cz)
Sat, 6 Jun 1998 11:21:02 +0200

Hi Linus,

I don't think it's wise to add __volatile__ to BIOS32 probing asm in
arch/i386/bios32.c. It's perfectly correct in the original version and it only
confuses certain broken compilers (some development versions of egcs AFAIK).
The right solution is to fix the compiler, not to add gibberish to the kernel.
Please apply the following patch.

Have a nice fortnight

-- 
Martin `MJ' Mares   <mj@ucw.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"If Windows is User-Friendly, why do you need to read a 426 pages manual?"




diff -u --recursive --new-file v2.1.103/linux/arch/i386/kernel/bios32.c linux/arch/i386/kernel/bios32.c
--- v2.1.103/linux/arch/i386/kernel/bios32.c    Wed May 20 19:10:37 1998
+++ linux/arch/i386/kernel/bios32.c     Thu May 21 14:13:15 1998
@@ -543,8 +543,7 @@
                pci_indirect.address = pcibios_entry + PAGE_OFFSET;


                save_flags(flags); cli();
-               __asm__ __volatile__(
-                       "lcall (%%edi)\n\t"
+               __asm__("lcall (%%edi)\n\t"
                        "jc 1f\n\t"
                        "xor %%ah, %%ah\n"
                        "1:"




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu