Re: 2.1.97 ide-scsi + IDE ZIP Drive => kernel panic

Gadi Oxman (gadio@netvision.net.il)
Tue, 21 Apr 1998 11:27:32 +0400 (IDT)


On Tue, 21 Apr 1998, Khimenko Victor wrote:

> In my try to test kernel for server on home comp I am got kernel panic in the
> ide-scsi.c in function idescsi_end_request() on line
> u8 *scsi_buf = pc->scsi_cmd->request_buffer;
> since pc->scsi_cmd was NULL.

Thanks for the report; the following patch should fix this.

Gadi

--- linux/drivers/scsi/ide-scsi.c.orig Tue Apr 21 11:21:45 1998
+++ linux/drivers/scsi/ide-scsi.c Tue Apr 21 11:21:53 1998
@@ -260,7 +260,7 @@
struct request *rq = hwgroup->rq;
idescsi_pc_t *pc = (idescsi_pc_t *) rq->buffer;
int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
- u8 *scsi_buf = pc->scsi_cmd->request_buffer;
+ u8 *scsi_buf;

if (rq->cmd != IDESCSI_PC_RQ) {
ide_end_request (uptodate, hwgroup);
@@ -282,6 +282,7 @@
printk ("ide-scsi: %s: suc %lu", drive->name, pc->scsi_cmd->serial_number);
if (!test_bit(PC_WRITING, &pc->flags) && pc->actually_transferred && pc->actually_transferred <= 1024 && pc->buffer) {
printk(", rst = ");
+ scsi_buf = pc->scsi_cmd->request_buffer;
hexdump(scsi_buf, IDE_MIN(16, pc->scsi_cmd->request_bufflen));
} else printk("\n");
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu