bug in tty_flip_buffer (tty.h) ?

Kernel Admin User (krnuser@temic-ech.spacenet.de)
Sat, 18 Apr 1998 19:59:23 +0200


Hello,

while looking trough the serial stuff I found this (2.1.96):

struct tty_flip_buffer {
struct tq_struct tqueue;
struct semaphore pty_sem;
char *char_buf_ptr;
unsigned char *flag_buf_ptr;
int count;
int buf_num;
unsigned char char_buf[2*TTY_FLIPBUF_SIZE];
char flag_buf[2*TTY_FLIPBUF_SIZE];
unsigned char slop[4]; /* N.B. bug overwrites buffer by 1 */
};

Should not use char_buf_ptr and char_buf the same type (char) ?
And flag_buf_ptr and flag_buf should use the same type (unsigned char) too ?
I think here is something mixed up.

Karsten Keil

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu