Re: A bug, a quirk/buglet, a minor cleanup, and a question...

A.N.Kuznetsov (kuznet@ms2.inr.ac.ru)
Sat, 21 Mar 1998 18:07:24 +0300


In article <Pine.LNX.3.96.980320153615.5271A-100000@sietch.sietch.bloomington.in.us> you wrote:
: The bug is this: the ppp0 interface no longer downs itself when it
: hangs up. I'm not sure why the code was ripped out of ppp_release() that
: did this, but I put it back.

We are deemed to live with this misfeature for a while.

The fix is wrong. Generally, we have no choice here, we cannot
down interface from ppp_tty_close, because it is called
from interrupt and with masked interrupts.
It is pppd, who is responsible for interface downing,
and it really does it.

: This code needs to be there or else the
: MOD_DEC_USE; is improper (if it gets removed with the device up, the net
: device list gets corrupted and reads from /proc/net/dev cause oopses and
: sometimes the whole shebang goes splat).

cleanup_module in ppp is absolutely wrong.
If you want to repair it, look at slip.c, it is supposed
to work.

Alexey Kuznetsov

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu