Re: quadstate patch for 2.1.81

Michael Elizabeth Chastain (mec@shout.net)
Sat, 24 Jan 1998 23:49:00 -0600


Hi Trevor and Everyone,

> the patch itself is at http://jpj.net/~trevor/linux/quadstate-2.1.81.diff.

I downloaded, proofread, and tested. It works great.

Trevor didn't mention this, but this patch fixes all the extraneous
sub-options that Menuconfig shows for disabled options. The root cause
is tests like this, which are wrong:

if [ "$CONFIG_FOO" != "n" ]; then

... because at the time Menuconfig parses its menus, "$CONFIG_FOO" has
the value "". The right test is:

if [ "$CONFIG_FOO" == "y" -o "$CONFIG_FOO" == "m" ]; then

I'm bringing this point up over and over because lots of different
people work on Config.in files so more people need to know about
this trap.

Anyways ... It Works For Me (TM).

Michael Chastain
<mailto:mec@shout.net>
"love without fear"