Re: Patch: ioctl MESS!

C. Scott Ananian (cananian@lcs.mit.edu)
Fri, 23 Jan 1998 04:23:11 -0500 (EST)


On Fri, 23 Jan 1998, Martin von Loewis wrote:

> > Enclosed is a patch to remove as much as possible of the duplicated ioctl
> > definitions into asm-generic. Currently, if one wants to add an ioctl to
> > the kernel, one has to patch asm-*/ioctls.h for every architecture
> > supported -- invariably missing one, or causing integration problems when
> > new architectures are merged into the standard kernel. By moving as many
> > ioctls as possible to asm-generic/ioctls.h, I attempt to limit the code
> > spread.
>
> Does this mean that user mode programs cannot get the definitions of
> these values, anymore? If you move them, why not into <linux/ioctl.h>?

Yes. My major goof was moving stuff where user-mode programs can't find
them. Next version will have the 'generic' ioctls in
include/linux/ioctl/ioctls.h. Also, I'm shifting to using the _IOC family
of #defines instead of cryptic 0x54XX constants as much as possible.
--Scott
@ @
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-oOO-(_)-OOo-=-=-=-=-=
C. Scott Ananian: cananian@lcs.mit.edu / Declare the Truth boldly and
Laboratory for Computer Science/Crypto / without hindrance.
Massachusetts Institute of Technology /META-PARRESIAS AKOLUTOS:Acts 28:31
-.-. .-.. .. ..-. ..-. --- .-. -.. ... -.-. --- - - .- -. .- -. .. .- -.
PGP key available via finger and from http://www.pdos.lcs.mit.edu/~cananian