Re: ip_forward, portptr

Steven Clarke (Steven.Clarke@ThePLAnet.net)
Thu, 22 Jan 1998 12:42:07 +0000 (GMT)


In article <Pine.LNX.3.96.980121121655.25318B-100000@dogbert.sitewerks.com> you wrote:
: I noticed this compiling 2.0.33. I don't know if it's important
: or not.

: fomit-frame-pointer -fno-strength-reduce -pipe -m486 -malign-loops=2
: -malign-jumps=2 -malign-functions=2 -DCPU=586 -DCONFIG_SMB_NT4 -c -o
: ip_forward.o ip_forward.c
: ip_forward.c: In function `ip_forward':
: ip_forward.c:326: warning: `portptr' might be used uninitialized in
: this function

My fault. Its in the masquerading MTU patch that went into 2.0.33. It's
not important but use the following patch if you want to get rid of it:

Steve Clarke

--- ip_forward.c.old Thu Jan 22 12:39:04 1998
+++ ip_forward.c Thu Jan 22 12:39:32 1998
@@ -323,7 +323,7 @@
#ifdef CONFIG_IP_MASQUERADE
__u32 premasq_saddr = iph->saddr;
__u16 premasq_sport = 0;
- __u16 *portptr;
+ __u16 *portptr = NULL;
long premasq_len_diff = skb->len;

if (iph->protocol==IPPROTO_UDP ||