Re: Small TCP-buglet in 2.1.80..

dan singhal (msinghal@r39h136.res.gatech.edu)
Wed, 21 Jan 1998 10:38:27 -0500 (EST)


On 21 Jan 1998, Andi Kleen wrote:

> I already sent a fix for this to Alan yesterday, but it seems it was too late
> or got lost.
>
> Here is the fix again:
>
> --- net/ipv4/tcp.c-o Tue Jan 20 00:28:04 1998
> +++ net/ipv4/tcp.c Tue Jan 20 00:29:31 1998
> @@ -614,7 +614,7 @@
> mask |= POLLIN | POLLRDNORM;
>
> #if 1 /* This needs benchmarking and real world tests */
> - space = sk->dst_cache->pmtu + 128;
> + space = (sk->dst_cache ? sk->dst_cache->pmtu : sk->mss) + 128;
> if (space < 2048) /* XXX */
> space = 2048;
> #else /* 2.0 way */

Uhm, I saw Linus post a patch earlier (which I applied) that changes it to #if 0
so it doesn't do anything, and this one changes internals ...

I'm wondering if both patches work, or if Linus' was a "It doesn't break now"
patch, and this is an actual fix ...

AKA -- does it matter which patch is used?

thanx

--dan