Re: Linux 2.1.72 - a few oddities.

David Woodhouse (dwmw2@cam.ac.uk)
Wed, 10 Dec 1997 11:02:09 +0000


Before I get flamed any more....

The patches below are _not_ mine. They are extracts from patch-2.1.72.
If you want to tell someone how silly they are, please don't tell me - I
already know. I was just pointing them out.

> Scanning through the patch file for 2.1.72, I'm a bit concerned about the
> following, for obvious reasons. "if(devc) vfree(devc);" is not a construct I'm
> particularly happy with, and three definitions of SO_BINDTODEVICE in
> asm-alpha/socket.h is a bit greedy, too.
>
>
>
> diff -u --recursive --new-file v2.1.71/linux/drivers/sound/uart401.c linux/drive
> rs/sound/uart401.c
> --- v2.1.71/linux/drivers/sound/uart401.c Sat Nov 29 11:25:11 1997
> +++ linux/drivers/sound/uart401.c Tue Dec 9 09:49:59 1997
> @@ -452,8 +452,7 @@
> if (!devc->share_irq)
> snd_release_irq(devc->irq);
>
> - /* Free device too !! - AC FIXME: CHECK THIS IS RIGHT */
> - if (devc)
> + if (!devc)
> vfree(devc);
> sound_unload_mididev(hw_config->slots[4]);
> }
> diff -u --recursive --new-file v2.1.71/linux/include/asm-alpha/socket.h linux/in
> clude/asm-alpha/socket.h
> --- v2.1.71/linux/include/asm-alpha/socket.h Sat Nov 1 11:04:27 1997
> +++ linux/include/asm-alpha/socket.h Tue Dec 9 09:31:19 1997
> @@ -37,10 +37,15 @@
>
> #define SO_PASSCRED 17
> #define SO_PEERCRED 18
> +#define SO_BINDTODEVICE 25
> +
> +#define SO_BINDTODEVICE 25
>
> /* Security levels - as per NRL IPv6 - don't actually do anything */
> #define SO_SECURITY_AUTHENTICATION 19
> #define SO_SECURITY_ENCRYPTION_TRANSPORT 20
> #define SO_SECURITY_ENCRYPTION_NETWORK 21
> +
> +#define SO_BINDTODEVICE 22
>
> #endif /* _ASM_SOCKET_H */
>
> --
> ---- ---- ----
> David Woodhouse, Robinson College, CB3 9AN, England. (+44) 0976 658355
> dwmw2@cam.ac.uk http://dwmw2.robinson.cam.ac.uk
> finger pgp@dwmw2.robinson.cam.ac.uk for PGP key.
>
>
>
>

-- 
----                              ----                              ----
David Woodhouse, Robinson College, CB3 9AN, England.   (+44) 0976 658355
	dwmw2@cam.ac.uk		http://dwmw2.robinson.cam.ac.uk
	    finger pgp@dwmw2.robinson.cam.ac.uk for PGP key.