Re: 8390 ethernet problem?

Keith Owens (kaos@ocs.com.au)
Sun, 05 Oct 1997 11:26:21 +1000


On Thu, 2 Oct 1997 00:32:16 -0400 (EDT),
Jon Lewis <jlewis@inorganic5.fdt.net> wrote:
>I got the following message earlier today:
>Oct 1 17:27:10 yoda kernel: eth0: Reentering the interrupt handler!
>isr=0x1 imr=0x0.
>the ethernet is an SMC Elite16T Ultra.

Can you try this patch against pre-2.0.31-9. For 2.1.x, the 8390 based
devices need SA_INTERRUPT in request_irq. I'm not convinced it is
required for 2.0.x SMP but give it a go.

--- linux/drivers/net/smc-ultra.c Thu Jun 6 16:54:05 1996
+++ patched/drivers/net/smc-ultra.c Sun Oct 5 10:10:06 1997
@@ -252,7 +252,7 @@
{
int ioaddr = dev->base_addr - ULTRA_NIC_OFFSET; /* ASIC addr */

- if (request_irq(dev->irq, ei_interrupt, 0, ei_status.name, NULL))
+ if (request_irq(dev->irq, ei_interrupt, SA_INTERRUPT, ei_status.name, NULL))
return -EAGAIN;

outb(0x00, ioaddr); /* Disable shared memory for safety. */