ARCnet IO-mapped cards completely fail with packets 221 < size < 224

David Woodhouse (D.W.Woodhouse@nortel.co.uk)
Thu, 18 Sep 1997 14:47:43 +0100

This is a multipart MIME message.

--===_0_Thu_Sep_18_14:46:56_BST_1997
Content-Type: text/plain; charset=us-ascii

Oops! I just noticed that the IO-mapped card drivers don't make up exception
packets properly.

I hereby declare myself to be this week's Official Mr F*&! All Good.

Here's the fix. One day I might even learn the language :)

--===_0_Thu_Sep_18_14:46:56_BST_1997
Content-Type: application/octet-stream
Content-Description: comdiff

--- linux/drivers/net/com20020.c.oops Sat Sep 6 18:05:42 1997
+++ linux/drivers/net/com20020.c Thu Sep 18 14:43:05 1997
@@ -215,7 +215,7 @@


static const char *version =
- "com20020.c: v2.92 97/09/02 Avery Pennarun <apenwarr@bond.net> et al.\n";
+ "com20020.c: v2.92a 97/09/18 Avery Pennarun <apenwarr@bond.net> et al.\n";

/****************************************************************************
* *
@@ -924,7 +924,8 @@
* frame.
*/

- put_whole_buffer(dev, lp->txbuf*512+offset,4,"\0\0xff\0xff\0xff");
+ put_buffer_byte(dev, lp->txbuf*512+offset,hdr[0]);
+ put_whole_buffer(dev, lp->txbuf*512+offset+1,3,"\377\377\377");
offset+=4;
}
else /* "other" Exception packet */
--- linux/drivers/net/com90io.c.oops Thu Sep 18 14:32:58 1997
+++ linux/drivers/net/com90io.c Thu Sep 18 14:44:02 1997
@@ -184,7 +184,7 @@


static const char *version =
- "com90io.c: v2.91 97/08/19 Avery Pennarun <apenwarr@bond.net> et al.\n";
+ "com90io.c: v2.92a 97/09/18 Avery Pennarun <apenwarr@bond.net> et al.\n";


/****************************************************************************
@@ -807,7 +807,8 @@
* frame.
*/

- put_whole_buffer(dev, lp->txbuf*512+offset,4,"\0\0xff\0xff\0xff");
+ put_buffer_byte(dev, lp->txbuf*512+offset,hdr[0]);
+ put_whole_buffer(dev, lp->txbuf*512+offset+1,3,"\377\377\377");
offset+=4;
}
else /* "other" Exception packet */

--===_0_Thu_Sep_18_14:46:56_BST_1997
Content-Type: text/plain; charset=us-ascii

David Woodhouse, CB3 9AN http://dwmw2.robinson.cam.ac.uk/
dwmw2@cam.ac.uk Tel: 0976 658355
D.W.Woodhouse@nortel.co.uk Tel: 01279 402332

--===_0_Thu_Sep_18_14:46:56_BST_1997--