Re: 1.1.49 cosmetic patches

Martin von Loewis (martin@mira.isdn.cs.tu-berlin.de)
Tue, 12 Aug 1997 09:17:17 +0200


> Also on binfmt_elf.c gcc barfs
> -----
> binfmt_elf.c: In function `load_elf_binary':
> binfmt_elf.c:392: warning: `interpreter_dentry' might be used uninitialized in this function
> -----

gcc is wrong on this one: interpreter_dentry will never be used
uninitialized. As Alan says, fix gcc not the Linux kernel. Adding an
extra mov instruction to the assembly just to make gcc happy is not
the way.

A better solution would be to rewrite this strange retval>=0 logic.
Also, it seems that the interpreter_dentry is never released in
case of a read_exec error.

Regards,
Martin