--TFS-with-MIME-and-DIME
Content-Type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: quoted-printable
Hello,
The beginning of schedule() function from kernel/sched=2Ec looks like this=20=
in=20
2=2E0=2E30:
asmlinkage void schedule(void)
{
int c;
struct task_struct * p;
struct task_struct * prev, * next;
unsigned long timeout =3D 0;
int this_cpu=3Dsmp_processor_id();
Shouldn't it rather look like this:
asmlinkage void schedule(void)
{
int c;
struct task_struct * p;
struct task_struct * prev, * next;
unsigned long timeout =3D 0;
#ifdef __SMP__
int this_cpu=3Dsmp_processor_id();
#endif
That saves as at least an assignment "int this_cpu =3D 0" if __SMP__ is not=
=20
defined=2E
I am perfectly aware that when compiled with -O6 it makes no difference bec=
ause=20
the variable is unused so gcc will optimize it away but it still looks nice=
r=20
(IMHO) with #ifdef __SMP__=2E
Tigran=2E
**********************************************************************
DST International Tel:+44 181 390 5000 www=2Edstinternational=2Eco=2Eu=
k=20
This message and any attachments to it is intended only for the=20
individual or company to which it is addressed and may contain=20
information which is privileged, confidential or prohibited from=20
disclosure or unauthorised use=2E If the recipient of this=20
transmission is not the intended recipient, or the employee or agent=20
responsible for delivering such materials to the intended recipient,=20
you are hereby notified that any use, any form of reproduction,=20
dissemination, copying, disclosure, modification, distribution and/or=20
publication of this e-mail message or its attachments other than by=20
its intended recipientis strictly prohibited by the sender=2E =20
If you have received it in error, please notify us immediately by=20
telephone on the number above and destroy the message and all copies=20
in your possession=2E
**********************************************************************
--TFS-with-MIME-and-DIME
Content-Type: text/rtf; name="MSGCC.RTF"
Content-transfer-encoding: base64
e1xydGYxXGFuc2kgXGRlZmYwXGRlZmxhbmcxMDI0e1xmb250dGJse1xmMFxm
cm9tYW4gVG1zIFJtbjt9e1xmMVxmcm9tYW4gU3ltYm9sO317XGYyXGZzd2lz
cyBIZWx2O319DQp7XGNvbG9ydGJsO1xyZWQwXGdyZWVuMFxibHVlMTI3O1xy
ZWQwXGdyZWVuMTI3XGJsdWUwO1xyZWQwXGdyZWVuMTI3XGJsdWUxMjc7XHJl
ZDEyN1xncmVlbjBcYmx1ZTA7DQpccmVkMTI3XGdyZWVuMFxibHVlMTI3O1xy
ZWQxMjdcZ3JlZW4xMjdcYmx1ZTA7XHJlZDEyN1xncmVlbjEyN1xibHVlMTI3
OztccmVkMFxncmVlbjBcYmx1ZTI1NTsNClxyZWQwXGdyZWVuMjU1XGJsdWUw
O1xyZWQwXGdyZWVuMjU1XGJsdWUyNTU7XHJlZDI1NVxncmVlbjBcYmx1ZTA7
XHJlZDI1NVxncmVlbjBcYmx1ZTI1NTsNClxyZWQyNTVcZ3JlZW4yNTVcYmx1
ZTA7XHJlZDI1NVxncmVlbjI1NVxibHVlMjU1O31ccGFwZXJ3MTIyNDBccGFw
ZXJoMTU4NDBcbWFyZ2wxODAwXG1hcmdyMTgwMFxtYXJndDE0NDBcbWFyZ2Ix
NDQwDQpcZ3V0dGVyMCBcZGVmZm9ybWF0XHNlY3RkIFxwYXJkXHBsYWluIHtc
cGxhaW4gXGYwIFxjYjcgXGNmMCBcY2I3IFxjZjkgSGVsbG8sXApcClxjYjcg
XGNmOSBUaGUgYmVnaW5uaW5nIG9mIHNjaGVkdWxlKCkgZnVuY3Rpb24gZnJv
bSBrZXJuZWwvc2NoZWQuYyBsb29rcyBsaWtlIHRoaXMgaW4gXApcY2I3IFxj
ZjkgMi4wLjMwOlwKXApcY2I3IFxjZjkgYXNtbGlua2FnZSB2b2lkIHNjaGVk
dWxlKHZvaWQpXApcY2I3IFxjZjkgXHtcClxjYjcgXGNmOSAgICAgaW50IGM7
XApcY2I3IFxjZjkgICAgIHN0cnVjdCB0YXNrX3N0cnVjdCAqIHA7XApcY2I3
IFxjZjkgICAgIHN0cnVjdCB0YXNrX3N0cnVjdCAqIHByZXYsICogbmV4dDtc
ClxjYjcgXGNmOSAgICAgdW5zaWduZWQgbG9uZyB0aW1lb3V0ID0gMDtcClxj
YjcgXGNmOSAgICAgaW50IHRoaXNfY3B1PXNtcF9wcm9jZXNzb3JfaWQoKTtc
ClwKXApcY2I3IFxjZjkgU2hvdWxkbid0IGl0IHJhdGhlciBsb29rIGxpa2Ug
dGhpczpcClwKXGNiNyBcY2Y5IGFzbWxpbmthZ2Ugdm9pZCBzY2hlZHVsZSh2
b2lkKVwKXGNiNyBcY2Y5IFx7XApcY2I3IFxjZjkgICAgIGludCBjO1wKXGNi
NyBcY2Y5ICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKiBwO1wKXGNiNyBcY2Y5
ICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKiBwcmV2LCAqIG5leHQ7XApcY2I3
IFxjZjkgICAgIHVuc2lnbmVkIGxvbmcgdGltZW91dCA9IDA7XApcY2I3IFxj
ZjkgI2lmZGVmIF9fU01QX19cClxjYjcgXGNmOSAgICAgaW50IHRoaXNfY3B1
PXNtcF9wcm9jZXNzb3JfaWQoKTtcClxjYjcgXGNmOSAjZW5kaWZcClwKXGNi
NyBcY2Y5IFRoYXQgc2F2ZXMgYXMgYXQgbGVhc3QgYW4gYXNzaWdubWVudCAi
aW50IHRoaXNfY3B1ID0gMCIgaWYgX19TTVBfXyBpcyBub3QgXApcY2I3IFxj
ZjkgZGVmaW5lZC5cClwKXGNiNyBcY2Y5IEkgYW0gcGVyZmVjdGx5IGF3YXJl
IHRoYXQgd2hlbiBjb21waWxlZCB3aXRoIC1PNiBpdCBtYWtlcyBubyBkaWZm
ZXJlbmNlIGJlY2F1c2UgXApcY2I3IFxjZjkgdGhlIHZhcmlhYmxlIGlzIHVu
dXNlZCBzbyBnY2Mgd2lsbCBvcHRpbWl6ZSBpdCBhd2F5IGJ1dCBpdCBzdGls
bCBsb29rcyBuaWNlciBcClxjYjcgXGNmOSAoSU1ITykgd2l0aCAjaWZkZWYg
X19TTVBfXy5cClwKXGNiNyBcY2Y5IFRpZ3Jhbi5cClxwYXIgfX1j
--TFS-with-MIME-and-DIME--