Re: low memory buffer cachebug fix, need some testers...

David S. Miller (davem@jenolan.rutgers.edu)
Mon, 9 Jun 1997 22:02:01 -0400


Date: Mon, 9 Jun 1997 13:34:06 +0200
From: "Dr. Werner Fink" <werner@suse.de>

--- /usr/src/linux/mm/page_alloc.c Sat Aug 17 20:19:29 1996
+++ /tmp/page_alloc.c Mon Jun 9 13:30:16 1997
@@ -214,7 +214,7 @@
return 0;
}
restore_flags(flags);
- if (priority != GFP_BUFFER && try_to_free_page(priority, dma, 1))
+ if (try_to_free_page(priority, dma, 1))
goto repeat;
return 0;
}

Without this change your patch may not have any effect on the swap behaviour.

Aha, good eyes. I've put this into my tree.

The only remaining issue is how try_to_free_page() does not try hard
enough, this is what causes gcc to die with a signal. My old "sleep
instead of fail" hack is not going back in, it is a kludge and can
create other problems.

I will look into a better fix for that one.

---------------------------------------------////
Yow! 11.26 MB/s remote host TCP bandwidth & ////
199 usec remote TCP latency over 100Mb/s ////
ethernet. Beat that! ////
-----------------------------------------////__________ o
David S. Miller, davem@caip.rutgers.edu /_____________/ / // /_/ ><