Re: bug leading to stuck pages

Mark Hemment (markhe@sco.COM)
Thu, 5 Jun 1997 14:17:40 +0100 (BST)


On Wed, 4 Jun 1997, Bill Hawes wrote:
> I've found a bug that looks like it could lead to a cascading loss of
> available memory under already-low low-memory situations.
> bh = create_buffers(page_address(page), size);
> if (!bh) {

Actually, create_buffers() will _never_ fail as get_more_buffer_heads()
will block until it can allocate a buffer-head, or one becomes free (and
buffers are never removed from unused_list with an interrupt).
So testing for failure is bogus, so the 'locked' condition does not exist.

Regards,

markhe

----------------------------------------------------
Mark Hemment UNIX/C Sotware Engineer (contractor)
"Success has many fathers. Failure is a b**tard"
----------------------------------------------------