Re: Diff against updated 3c59x.c for Boomerang boards

Nathan Bryant (nathan@burgessinc.com)
Fri, 4 Apr 1997 12:35:30 -0500 (EST)


On Fri, 4 Apr 1997, Nathan Bryant wrote:

> Howdy, hackers,
>
> David Miller recently discovered a memory leak that exists in most of the
> Linux network drivers. I believe the updated 3c59x.c (for Boomerang
> cards) on http://cesdis.gsfc.nasa.gov/linux/ suffers from this problem;
> here's a diff which I think should correct it.
>
> --- 3c59x.c~ Fri Apr 4 11:08:59 1997
> +++ 3c59x.c Fri Apr 4 11:37:07 1997
> @@ -1025,6 +1025,7 @@
> /* dev->tbusy = 0;*/
> vp->stats.tx_errors++;
> vp->stats.tx_dropped++;
> + dev_kfree_skb(skb, FREE_WRITE);
> }
>
> static int
>
>

Sorry, folks, that's a bad patch. This one actually compiles cleanly :)

--- 3c59x.c.stock Fri Apr 4 12:31:21 1997
+++ 3c59x.c Fri Apr 4 12:28:19 1997
@@ -1046,6 +1046,7 @@
if (jiffies - dev->trans_start < TX_TIMEOUT)
return 1;
vortex_tx_timeout(dev);
+ dev_kfree_skb(skb, FREE_WRITE);
return 1;
}