Re: 3c590

Matthias Urlichs (smurf@noris.de)
11 Dec 1996 18:02:46 +0100

In linux.dev.kernel, article <199612101828.KAA00877@luna.inside.sealabs.com>,
Phillip Dillinger <Phillip.Dillinger@sealabs.com> writes:
>
> Now that I am on the vortex list, I hope to work with Donald Becker because
> he has all of the experience already with net drivers.
>
Here's a small thinko... I think that _should_ be the reason peole see
these access conflicts/lcokouts with heavy load:

diff -u kernel/linux/drivers/net/3c59x.c:1.1.1.5 kernel/linux/drivers/net/3c59x.c:1.4
--- kernel/linux/drivers/net/3c59x.c:1.1.1.5 Fri Nov 8 18:29:55 1996
+++ kernel/linux/drivers/net/3c59x.c Mon Dec 2 12:46:19 1996
@@ -783,7 +868,11 @@
vp->stats.tx_dropped++;
return 0; /* Yes, silently *drop* the packet! */
}
- dev->tbusy = 0;
+ }
+
+ if(skb == NULL) {
+ dev_tint(dev);
+ return NULL;
}

/* Block a timer-based transmit from overlapping. This could better be

-- 
To my mind the old masters are not art; their value is in their
sanctity.
                                -- Thomas A. Edison

-- 
Matthias Urlichs         \  noris network GmbH  /  Xlink-POP Nürnberg 
Schleiermacherstraße 12   \   Linux+Internet   /   EMail: urlichs@noris.de
90491 Nürnberg (Germany)   \    Consulting+Programming+Networking+etc'ing
   PGP: 1024/4F578875   1B 89 E2 1C 43 EA 80 44  15 D2 29 CF C6 C7 E0 DE
       Click <A HREF="http://info.noris.de/~smurf/finger">here</A>.    42