Re: Please don't beat me up (was Re: Bugs and wishes in memory management area)

Gerd Knorr (kraxel@cs.tu-berlin.de)
Wed, 27 Nov 1996 10:18:56 +0100

Newsgroups: linux.dev.kernel
Path: kraxel
From: kraxel@cs.tu-berlin.de (Gerd Knorr)
Subject: Re: A minor bug in sr_ioctl.c for 2.1.13?
X-Newsreader: NN version 6.5.0 (NOV)
Organization: my small flat somewhere in berlin
Message-ID: <E1Iv7I.8q@cs.tu-berlin.de>
References: <3299f42b.20761@mail.cybernex.net> <329ba754.111772@mail.cybernex.net>
Date: Wed, 27 Nov 1996 09:18:54 GMT

tenthumbs@cybernex.net writes:

>This time I realized I should see what's actually going on. At about line
>341 in sr_ioctl.c where the code is

> if (copy_to_user ((void *) arg, &tochdr, sizeof (struct cdrom_tochdr)))
> result = -EFAULT;

Yes, in 2.1.12 someone added this copy_*_user stuff. This is *wrong*, as this
function gets a _kernel_ pointer from the gerneric cdrom driver. Just reverse
the 2.1.12 patch for sr_ioctl.c, and audio works again.

Gerd

-- 

--
Gerd Knorr <kraxel@cs.tu-berlin.de> | http://wwwwbs.cs.tu-berlin.de/~kraxel/


Linux hackers are funny people: They count the time in patchlevels.