make xconfig broken by NCR53C8XX

Gerard Roudier (groudier@club-internet.fr)
Sat, 6 Jul 1996 18:00:12 +0000 (GMT)


Hello,

Here is a fix Andreas Koppenhoefer has reported to me.

Yesterday Andreas wrote:

> Today I've tried ncrBsd2Linux-1.11. After patching Linux by
> Install2.ncr53c8xx 'make xconfig' was broken.

> Main problem is xconfig doesn't allow for alternate dep_tristate
> statements in Config.in. Maybe this should be fixed in xconfig? With
> this patch 'make xconfig' will be happy again. Another problem is
> argument 'm' in dep_tristate which is not recognized as literal, too.

The patch for linux-2.0.3 should be the following:
("make xconfig" works for me now)

-----------------------------------------------------------------------
--- /tmp/linux/drivers/scsi/Config.in Sat Jul 6 16:09:01 1996
+++ linux/drivers/scsi/Config.in Sat Jul 6 17:13:28 1996
@@ -45,11 +45,7 @@
fi
fi
if [ "$CONFIG_PCI" = "y" -a "$CONFIG_SCSI_NCR53C7xx" != "y" ]; then
- if [ "$CONFIG_SCSI" != "n" -a "$CONFIG_SCSI_NCR53C7xx" = "m" ]; then
- dep_tristate 'NCR53C8XX SCSI support' CONFIG_SCSI_NCR53C8XX m
- else
- dep_tristate 'NCR53C8XX SCSI support' CONFIG_SCSI_NCR53C8XX $CONFIG_SCSI
- fi
+ dep_tristate 'NCR53C8XX SCSI support' CONFIG_SCSI_NCR53C8XX $CONFIG_SCSI
if [ "$CONFIG_SCSI_NCR53C8XX" != "n" ]; then
bool ' enable tagged command queueing' CONFIG_SCSI_NCR53C8XX_TAGGED_QUEUE
bool ' force normal IO' CONFIG_SCSI_NCR53C8XX_IOMAPPED
@@ -57,7 +53,7 @@
bool ' force asynchronous transfer mode' CONFIG_SCSI_NCR53C8XX_FORCE_ASYNCHRONOUS
bool ' force synchronous negotiation' CONFIG_SCSI_NCR53C8XX_FORCE_SYNC_NEGO
fi
- if [ "$CONFIG_SCSI_NCR53C8XX" != "n" -a $CONFIG_EXPERIMENTAL = 'y' ]; then
+ if [ "$CONFIG_SCSI_NCR53C8XX" != "n" -a "$CONFIG_EXPERIMENTAL" = "y" ]; then
bool ' disable master parity checking' CONFIG_SCSI_NCR53C8XX_DISABLE_MPARITY_CHECK
bool ' disable scsi parity checking' CONFIG_SCSI_NCR53C8XX_DISABLE_PARITY_CHECK
fi
--------------------------------------------------------------------------

Regards, Gerard.