BUG: 1.3.96(modules) - drivers/scsi/NCR5380.h:301: conflicting types for `pas16_reset'

Andrew C. Esh (andrewes@cnt.com)
Mon, 29 Apr 1996 14:45:52 -0500

BUG:
make modules
...
gcc -D__KERNEL__ -I/usr2/src/linux/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
-fno-strength-reduce -pipe -m486 -DCPU=486 -DMODULE -DMODVERSIONS -include
/usr2/src/linux/include/linux/modversions.h -c -o st.o st.c
In file included from pas16.c:119:
NCR5380.h:301: conflicting types for `pas16_reset'
pas16.h:121: previous declaration of `pas16_reset'
In file included from pas16.c:568:
NCR5380.c:3238: conflicting types for `pas16_reset'
NCR5380.h:301: previous declaration of `pas16_reset'
pas16.c:572: warning: initialization from incompatible pointer type
make[2]: *** [pas16.o] Error 1

POSSIBLE PROBLEM:

andrewes:/usr/src/linux/drivers/scsi# grep pas16_reset *.h
pas16.h:int pas16_reset(Scsi_Cmnd *); <--- pas16_reset defined
pas16.h: NULL, pas16_queue_command, pas16_abort, pas16_reset, NULL, \
pas16.h:#define NCR5380_reset pas16_reset <--- Set the same as NCR5380_reset

andrewes:/usr/src/linux/drivers/scsi# grep NCR5380_reset *.h
NCR5380.h:#ifndef NCR5380_reset
NCR5380.h:int NCR5380_reset (Scsi_Cmnd *cmd, unsigned int); <--- It's not the same as this
dtc.h:#define NCR5380_reset dtc_reset
g_NCR5380.h:int generic_NCR5380_reset(Scsi_Cmnd *); <--- I think pas16_reset should be this instead.
g_NCR5380.h: generic_NCR5380_reset, NULL, \
g_NCR5380.h:#define NCR5380_reset generic_NCR5380_reset
pas16.h:#define NCR5380_reset pas16_reset
t128.h:#define NCR5380_reset t128_reset <--- t128 may have the same problem

Unfortunately, once pas16_reset is defined as generic_NCR5380_reset, then
NCR5380.c won't compile, for the opposite reason. Maybe my thinking is
backwards on this.

Since pas16 isn't critical to my system, I'm going to drop
it from the kernel, and simply report this bug and wait for a fix. 

-- 
Andrew C. Esh			mailto:andrew_esh@cnt.com
Computer Network Technology	andrewes@mtn.org (finger for PGP key)
6500 Wedgwood Road		612.550.8000 (main)
Maple Grove MN 55311		612.550.8229 (direct)
http://www.cnt.com - CNT Inc. Home Page
http://www.mtn.org/~andrewes - ACE Home Page