Re: [PATCH v4 0/3] mmc: sdhci-cadence: SD6HC DDR50/DDR52 read-path tuning and fixes

From: Krzysztof Kozlowski

Date: Sun Nov 22 2026 - 11:03:27 EST


On Thu, Nov 19, 2026 at 05:45:32PM +0800, tze.yee.ng@xxxxxxxxxx wrote:
> From: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
>
> This series enables the extended-read DDR modes - SD DDR50 and eMMC
> DDR52 - on the Cadence SD6HC (SD/eMMC v6) PHY. Neither mode runs a host
> tuning sequence (CMD19/CMD21), so the read path must be centred by
> static, board/SoC-characterised PHY settings. Bringing it up on Agilex5
> also exposed PHY issues affecting the existing tuned modes.
>
> - Patch 1: abort a failed tuning command on SD6HC. The software tuning
> loop never aborted a command that errored, so after a CMD21 command
> error the eMMC could stay in the Data state and time out the CMD6
> that HS400 selection issues next; mmc_send_abort_tuning() clears it
> (a no-op for SD). Limited to SD6HC since the path is shared with the
> untested SD4HC.
> - Patch 2: document two optional SD6HC read-path properties for the
> extended-read DDR modes (SD DDR50, eMMC DDR52).
> - Patch 3: program PHONY_DQS_TIMING, which was left 0 in all modes; in
> extended-read mode it must be the rebar pulse width in clk_phy
> cycles minus 1, else one DDR beat is duplicated. The width is now
> derived from the SDCLK/sdmclk divider rather than hard-coded. The
> same patch reads the new properties at probe and applies them in
> DDR50 and DDR52, and makes the DQS_TIMING update clear USE_LPBK_DQS
> before reprogramming it so the loopback/phony selection takes
> effect.
>
> The new cdns,ddr-* properties are unused in this series; they will be
> consumed by the socfpga_agilex5_socdk and socfpga_agilex5_socdk_emmc
> device trees, submitted as a separate series.
>
> Tested on Agilex5 SoCDK: SD DDR50, eMMC DDR52 and eMMC HS400.
>
> Signed-off-by: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
> ---
> Changes in v4:
> - Merged v3 2/4 (PHONY_DQS_TIMING) and v3 4/4 (read DDR tuning from
> device tree) into a single driver patch, now 3/3, and moved it after
> the binding patch. The series is now 3 patches. (Tanmay Kathpalia)
> - Patch 1: limited the abort to SD6HC (host->version >= SDHCI_SPEC_420)
> because sdhci_cdns_execute_tuning() is shared with SD4HC, which has
> not been tested; reworded the commit message accordingly. Added Tanmay's
> Reviewed-by.
> - Patch 2: dropped the cdns,ddr-phony-dqs-timing property; the phony DQS
> timing is always derived by the driver. (Tanmay Kathpalia)
> - Patch 2: dropped Krzysztof's Reviewed-by since property set changed. The
> two remaining properties are unchanged from v3; Krzysztof, happy to
> carry your tag again if the reduced binding looks fine.

Not a reason to drop the tag, really. Why would less custom properties
be something needing to be re-reviewed.

Best regards,
Krzysztof