Re: [PATCH v2 2/8] ARM: dts: rockchip: Add support for RK3506

From: Andrew Lunn

Date: Sun Nov 22 2026 - 10:47:06 EST


> diff --git a/arch/arm/boot/dts/rockchip/rk3506.dtsi b/arch/arm/boot/dts/rockchip/rk3506.dtsi

> + gmac0: ethernet@ff4c8000 {
> + compatible = "rockchip,rk3506-gmac", "snps,dwmac-4.20a";
> + reg = <0xff4c8000 0x2000>;
> + clocks = <&cru CLK_MAC0>, <&cru CLK_MAC0_PTP>,
> + <&cru PCLK_MAC0>, <&cru ACLK_MAC0>;
> + clock-names = "stmmaceth", "ptp_ref",
> + "pclk_mac", "aclk_mac";
> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + phy-mode = "rmii";

Sorry, missed this on the first pass of the patchset.

phy-mode is generally a board/PCB property, not a SoC property. It
would only be a SoC property when the SoC cannot do anything other
than RMII. But given this is snps,dwmac, i expect it can do other phy
modes.

Andrew