Re: [PATCH v5 3/3] soundwire: qcom: check clk_prepare_enable() return values
From: Daniel Carter
Date: Sun Nov 22 2026 - 10:41:16 EST
Hi Vinod,
A friendly ping on this one - it already has Srini's Reviewed-by and carries
Fixes: tags plus Cc: stable.
One rebase note: the patch was written against v7.4-rc2, and your fixes
branch has since gained "soundwire: qcom: disable the interrupt before
gating the clock", which shifts the runtime-resume hunk. I verified it
applies cleanly on top of your fixes branch (apply + build + checkpatch
clean), with the error path still returning before enable_irq():
- clk_prepare_enable(ctrl->hclk);
+ ret = clk_prepare_enable(ctrl->hclk);
+ if (ret)
+ return ret;
+
enable_irq(ctrl->irq);
If you would like it for the current -rc cycle, I can resend it rebased on
soundwire/fixes; otherwise it can wait for the next merge window. Either
way, let me know if you want anything changed.
Best regards,
Daniel Carter