Re: [PATCH] smb: client: convert DFS target node name from cache charset on mount

From: kernel test robot

Date: Sun Nov 22 2026 - 06:51:33 EST


Hi Fredric,

kernel test robot noticed the following build errors:

[auto build test ERROR on manguebit/cifs-next]
[also build test ERROR on manguebit/cifs-fixes linus/master v7.4-rc3 next-20261120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Fredric-Cover/smb-client-convert-DFS-target-node-name-from-cache-charset-on-mount/20261122-045840
base: https://git.manguebit.org/linux.git cifs-next
patch link: https://lore.kernel.org/r/20261122045841.99012-1-fredric.cover.lkernel%40gmail.com
patch subject: [PATCH] smb: client: convert DFS target node name from cache charset on mount
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20261122/202611221905.fQpuvetd-lkp@xxxxxxxxx/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261122/202611221905.fQpuvetd-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611221905.fQpuvetd-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

fs/smb/client/dfs.c: In function 'dfs_parse_target_referral':
>> fs/smb/client/dfs.c:44:21: error: implicit declaration of function 'dfs_cache_local_path'; did you mean 'dfs_cache_canonical_path'? [-Wimplicit-function-declaration]
44 | node_name = dfs_cache_local_path(ref->node_name, ctx->local_nls);
| ^~~~~~~~~~~~~~~~~~~~
| dfs_cache_canonical_path
>> fs/smb/client/dfs.c:44:19: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
44 | node_name = dfs_cache_local_path(ref->node_name, ctx->local_nls);
| ^


vim +44 fs/smb/client/dfs.c

13
14 /**
15 * dfs_parse_target_referral - set fs context for dfs target referral
16 *
17 * @full_path: full path in UNC format.
18 * @ref: dfs referral pointer.
19 * @ctx: smb3 fs context pointer.
20 *
21 * Return zero if dfs referral was parsed correctly, otherwise non-zero.
22 */
23 int dfs_parse_target_referral(const char *full_path, const struct dfs_info3_param *ref,
24 struct smb3_fs_context *ctx)
25 {
26 int rc;
27 const char *prepath = NULL;
28 char *node_name = NULL;
29 char *path;
30
31 if (!full_path || !*full_path || !ref || !ctx)
32 return -EINVAL;
33
34 if (WARN_ON_ONCE(!ref->node_name || ref->path_consumed < 0))
35 return -EINVAL;
36
37 if ((size_t)ref->path_consumed < strlen(full_path)) {
38 prepath = full_path + ref->path_consumed;
39 /* skip initial delimiter */
40 if (*prepath == '/' || *prepath == '\\')
41 prepath++;
42 }
43
> 44 node_name = dfs_cache_local_path(ref->node_name, ctx->local_nls);
45 if (IS_ERR(node_name))
46 return PTR_ERR(node_name);
47
48 path = cifs_build_devname(node_name, prepath);
49 kfree(node_name);
50 if (IS_ERR(path))
51 return PTR_ERR(path);
52
53 rc = smb3_parse_devname(path, ctx);
54 if (rc)
55 goto out;
56
57 rc = dns_resolve_unc(DFS_DOM(ctx), path,
58 (struct sockaddr *)&ctx->dstaddr);
59 out:
60 kfree(path);
61 return rc;
62 }
63

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki