Re: [PATCH 3/4] media: rkvdec: Add VP9 support for VDPU381 variant

From: Igor Velkov

Date: Sat Nov 21 2026 - 19:38:49 EST


On Sun, Jul 26, 2026 at 03:25:36PM -0500, Venkata Atchuta Bheemeswara
Sarma Darbha wrote:
> + for (i = 0; i < ARRAY_SIZE(lf->ref_deltas); i++)
> + regs->vp9_param.reg94.vp9_ref_deltas_lastframe |=
> + (lf->ref_deltas[i] & 0x7f) << (7 * i);
> +
> + for (i = 0; i < ARRAY_SIZE(lf->mode_deltas); i++)
> + regs->vp9_param.reg75.vp9_mode_deltas_lastframe |=
> + (lf->mode_deltas[i] & 0x7f) << (7 * i);

vp9_ctx->regs is allocated once in rkvdec_vp9_start() and
config_registers() does not clear it, so these two fields accumulate
the deltas of all previous inter frames: a stream that changes the loop
filter deltas gets the OR of the old and the new values.

The same goes for config_seg_registers(): the *_en bits and their values
are only written while the feature is enabled, so they stay set when a
later frame disables it. rkvdec-vp9.c has the same code there.

The VDPU381 H.264 and HEVC backends start config_registers() with
memset(regs, 0, sizeof(*regs)); the same here would cover both.

Found by reading the code; I have no RK3588 board to show it on a
stream.

Igor