RE: [PATCH] mshv: Handle completions on repeat hypercall failures
From: Michael Kelley
Date: Sat Nov 21 2026 - 18:30:32 EST
From: Mukesh R <mrathor@xxxxxxxxxxxxxxxxxxx> Sent: Thursday, November 19, 2026 6:09 PM
>
> When a repeat hypercall fails, it could still have completed some of the
> entries requested. Fix places where completions are not checked in case
> of repeat hypercall failures. Also, add error prints in couple places
> with correct partial completion counts when repeat hypercall fails.
>
> Signed-off-by: Mukesh R <mrathor@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Michael Kelley <mhklinux@xxxxxxxxxxx>
> ---
> drivers/hv/mshv_common.c | 17 +++++++++++++----
> drivers/hv/mshv_root_hv_call.c | 15 +++++++++------
> 2 files changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hv/mshv_common.c b/drivers/hv/mshv_common.c
> index 63f09bb5136e..580248a490ac 100644
> --- a/drivers/hv/mshv_common.c
> +++ b/drivers/hv/mshv_common.c
> @@ -56,8 +56,6 @@ int hv_call_get_vp_registers(u32 vp_index, u64 partition_id, u16 count,
>
> status = hv_do_rep_hypercall(HVCALL_GET_VP_REGISTERS, rep_count,
> 0, input_page, output_page);
> - if (!hv_result_success(status))
> - break;
>
> completed = hv_repcomp(status);
> for (i = 0; i < completed; ++i)
> @@ -65,6 +63,13 @@ int hv_call_get_vp_registers(u32 vp_index, u64 partition_id, u16 count,
>
> registers += completed;
> remaining -= completed;
> +
> + if (!hv_result_success(status)) {
> + pr_err("%s: count:%d comp:%d rem:%ld st:0x%llx\n",
> + __func__, count, completed, remaining, status);
> + break;
> + }
> +
> }
> local_irq_restore(flags);
>
> @@ -99,12 +104,16 @@ int hv_call_set_vp_registers(u32 vp_index, u64 partition_id, u16 count,
>
> status = hv_do_rep_hypercall(HVCALL_SET_VP_REGISTERS, rep_count,
> 0, input_page, NULL);
> - if (!hv_result_success(status))
> - break;
>
> completed = hv_repcomp(status);
> registers += completed;
> remaining -= completed;
> +
> + if (!hv_result_success(status)) {
> + pr_err("%s: count:%d comp:%d rem:%ld st:0x%llx\n",
> + __func__, count, completed, remaining, status);
> + break;
> + }
> }
>
> local_irq_restore(flags);
> diff --git a/drivers/hv/mshv_root_hv_call.c b/drivers/hv/mshv_root_hv_call.c
> index e761addda50e..6261686c3638 100644
> --- a/drivers/hv/mshv_root_hv_call.c
> +++ b/drivers/hv/mshv_root_hv_call.c
> @@ -239,6 +239,7 @@ static int hv_do_map_gpa_hcall(u64 partition_id, u64 gfn, u64 page_struct_count,
> local_irq_restore(irq_flags);
>
> completed = hv_repcomp(status);
> + done += completed;
>
> if (hv_result_needs_memory(status)) {
> ret = hv_deposit_memory(partition_id, status);
> @@ -246,11 +247,13 @@ static int hv_do_map_gpa_hcall(u64 partition_id, u64 gfn, u64 page_struct_count,
> break;
>
> } else if (!hv_result_success(status)) {
> + pr_err("%s: failed to map pages at gfn %#llx: done %u/%llu, flags=%#x, status=%#llx (%s)\n",
> + __func__, gfn, done, page_count, flags, status,
> + hv_result_to_string(hv_result(status)));
> +
> ret = hv_result_to_errno(status);
> break;
> }
> -
> - done += completed;
> }
>
> if (ret && done) {
> @@ -358,18 +361,18 @@ int hv_call_get_gpa_access_states(u64 partition_id, u32 count, u64 gpa_base_pfn,
>
> status = hv_do_rep_hypercall(HVCALL_GET_GPA_PAGES_ACCESS_STATES, rep_count,
> 0, input_page, output_page);
> - if (!hv_result_success(status)) {
> - local_irq_restore(flags);
> - break;
> - }
> completed = hv_repcomp(status);
> for (i = 0; i < completed; ++i)
> states[i].as_uint8 = output_page[i].as_uint8;
>
> local_irq_restore(flags);
> +
> states += completed;
> *written_total += completed;
> remaining -= completed;
> +
> + if (!hv_result_success(status))
> + break;
> }
>
> return hv_result_to_errno(status);
> --
> 2.51.2.vfs.0.1
>