Re: [PATCH net] vlan: require real device netns admin to change GVRP and MVRP
From: Jakub Kicinski
Date: Sat Nov 21 2026 - 18:15:40 EST
On Tue, 17 Nov 2026 13:04:41 +0000 Suyuan Wang via B4 Relay wrote:
> The same gap in macsec was fixed in commit ed502e485685 ("macsec:
> require CAP_NET_ADMIN in the device netns for changelink"). Its author
> described the identical VLAN case there and said a separate VLAN patch
> would follow; I could not find one on netdev, so this is sent
> independently.
We can apply this as hardening but I'm not sure this is an issue.
netns can already "disable" the vlan by deleting the interface.
I guess we shouldn't let netns enable the vlan. But then again
I don't see the use case for having a vlan that's not announced,
or the harm announcing it would cause.